Fix incorrect early exit from contain_mutable_functions_walker. Given a JsonExpr.path_spec that is a null constant, contain_mutable_functions_walker immediately returned false, failing to check for other sources of mutability elsewhere in the JsonExpr. It must only skip the jspIsMutable() test in this case.
While here, remove a couple of redundant castNode calls (I'm not a fan of using that directly after an explicit IsA check). Bug: #19840 Reported-by: chunling qin <[email protected]> Author: Tom Lane <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/69bccbbaef0a4868b409c07444ed10e1193c4d4a Modified Files -------------- src/backend/optimizer/util/clauses.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
