Make GetSnapshotData() more resilient on out-of-memory errors If the allocation of Snapshot->subxip fails, a follow-up call of GetSnapshotData() would see a partially-initialized snapshot, causing a NULL dereference on reentry when using "subxip" because only "xip" would be allocated. In the event of an out-of-memory error when allocating "subxip", "xip" is now reset before throwing an ERROR, so as Snapshots can be allocated and handled gracefully on retry.
Note: This has been originally applied in v19~ as of 29fb598b9cad, and was initially not backpatched. This issue has been seen in the field on older stable branches, hence the backpatch now. Reported-by: Alexander Lakhin <[email protected]> Author: Matthias van de Meent <[email protected]> Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/CAJ7c6TO+7rrN5H_Odd8PLdmrEa4MgeoJ2AqnTydOcy=ayzv...@mail.gmail.com Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bdae2f8eaab09222dc4e3562d712e6580711ccf9 Modified Files -------------- src/backend/storage/ipc/procarray.c | 8 ++++++++ 1 file changed, 8 insertions(+)
