Further varnullingrels fixes for MERGE WHEN NOT MATCHED BY SOURCE. Commit 259a0a99fe3 fixed a "wrong varnullingrels" error in MERGE with WHEN NOT MATCHED BY SOURCE actions by marking any Vars referring to the source relation as nullable by the join. However, that overlooked the fact that the source relation might itself be a join relation, and there may be Vars referring to relations under the source join. Depending the query, this could lead to further "wrong varnullingrels" errors or incorrect query results.
Fix by ensuring that all Vars referring to the source join relation or any relations under it are marked as nullable by the merge join. Back-patch to v17, where WHEN NOT MATCHED BY SOURCE support was added to MERGE. Reported-by: Shihao Zhong <[email protected]> Author: Shihao Zhong <[email protected]> Reviewed-by: Dean Rasheed <[email protected]> Discussion: https://postgr.es/m/CAGRkXqR7VXacmRP41UBaM5u4aseeCH5ECVmQgn_YS%3DL7%3DxdhTw%40mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cf44f3fa19b6c35633e043621d325d55a760e472 Modified Files -------------- src/backend/optimizer/prep/prepjointree.c | 16 ++++++++--- src/test/regress/expected/merge.out | 45 ++++++++++++++++++++++++++++++- src/test/regress/sql/merge.sql | 28 ++++++++++++++++++- 3 files changed, 83 insertions(+), 6 deletions(-)
