Fix use-after-free in pg_show_all_settings().

Commit 3057465acfbe changed show_all_settings(), used by the
pg_show_all_settings() SQL function, to collect pointers to all GUC
entries on its first call and return one row per call from that saved
array.  When a module is loaded while the scan is still in progress,
the placeholder entries for that module's prefix are replaced and
freed, while the saved array keeps pointing at them.  That caused a
use-after-free.  Depending on what reused the freed chunk, the scan
returns stale rows or the backend crashes.

Fix this by using the materialize mode for show_all_settings() so that
the GUC array is consumed before any other expression in the query can
run and free an entry.  This is also how the sibling function
show_all_file_settings() already works.  We only have a few hundred
GUCs in practice, so materializing them all is acceptable.

Backpatch to v16, where that commit first appeared.  On v15 and
earlier show_all_settings() reads each GUC entry by number on every
call and never keeps a pointer across calls, so it is not affected.

Reported-by: Stephan Lipp <[email protected]>
Reviewed-by: Greg Burd <[email protected]>
Backpatch-through: 16
Security: CVE-2026-120152

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/921b93f250f65c730c2d21b71d7535074f79663e
Author: Masahiko Sawada <[email protected]>

Modified Files
--------------
src/backend/utils/misc/guc_funcs.c | 118 ++++++++-----------------------------
1 file changed, 24 insertions(+), 94 deletions(-)

Reply via email to