pg_basebackup: Fix use of externally-controlled format string

appendPQExpBuffer() was accidentally used instead of
appendBinaryPQExpBuffer() in pg_basebackup.  The former would
interpret the string to be appended as a format string, which could
lead to misbehavior.  (The string contents are related to backup
manifest contents.  Those do not normally contain any data that could
look like a format placeholders.  In order for this to misbehave,
files with unusual names would have to exist in the data directory.)

- The hunk in ReceiveBackupManifestInMemoryChunk() is from commit
  0d8c9c1210c, 2020, PG13.  This is only reachable against a pre-PG15
  server, because of the next item.

- The hunk in ReceiveArchiveStreamChunk() is from commit cc333f32336,
  2022, PG15.

Security: CVE-2026-16240
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/af250ef26280d49ef301c9c64b0d4740180c8821
Author: Peter Eisentraut <[email protected]>

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Reply via email to