Handle composite type changes in ExecEvalFieldStore[De]Form The composite type may be modified during execution, e.g. between deforming and forming a value, but the executor code ignored that and could have deformed/formed the tuple with a mismatching descriptor. The consequences could be severe, including reading/writing memory, etc.
Fixed by remembering the descriptor in ExecInitExprRec(), and using it when deforming and forming tuples later, instead of looking up a new descriptor. This is the same approach already used for RowExpr. This means attributes added after initializing the descriptor will be treated as NULL, and dropped attributes will be removed from the tuple. Technically, this is an ABI break. It modifies the ExprEvalStep, which is part of the ABI. The meaning of one pointer (replacing rowcache with tupdesc) changes, and ncolumns gets removed. Neither changes the layout or size of the struct, and so should be backwards compatible. It could have a bigger impact on custom JIT providers, but we've not found any. Reported-by: OpenAI Codex Security Reported-by: Bronson Yen <[email protected]> Reported-by: Mehmet D. INCE <[email protected]> Author: Tomas Vondra <[email protected]> Co-Authored-by: Heikki Linnakangas <[email protected]> Reviewed-by: Andres Freund <[email protected]> Security: CVE-2026-116306 Backpatch-through: 14 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2ac7e6e8a56587e8976b1ebb3c8cf9e1de98346d Author: Tomas Vondra <[email protected]> Modified Files -------------- src/backend/executor/execExpr.c | 31 +++++--- src/backend/executor/execExprInterp.c | 26 +------ src/include/executor/execExpr.h | 5 +- src/test/regress/expected/rowtypes.out | 132 +++++++++++++++++++++++++++++++++ src/test/regress/sql/rowtypes.sql | 131 ++++++++++++++++++++++++++++++++ 5 files changed, 286 insertions(+), 39 deletions(-)
