Fix use-after-free issues due to drop of portals being set up

Between CreatePortal() and PortalStart(), a portal can run user-defined
code due to planning and executor startup, like SQL functions.  A
function attempting to close a portal would free it, without its creator
knowing about it.  This could lead to use-after-free issues when trying
to use portals that have already been closed.

With this change, PortalDrop() now refuses to act on portals marked as
PORTAL_NEW or PORTAL_DEFINED.  CLOSE ALL skips them, as it does for
active portals.  Note that AtAbort_Portals() (for transaction aborts)
and AtSubAbort_Portals() (for subtransaction aborts) now puts such
portals in a failed state so as they can be cleaned up during error
cleanup.

Two sets of tests are added:
- Portal manipulations during planning and executor startup.
- Portals and Bind messages, relying on injection points to check
various transaction cases with portals marked as either PORTAL_NEW or
PORTAL_DEFINED, where the on-error cleanup of portals marked as failed
matters.

Reported-by: Tomas Vondra <[email protected]>
Author: Michael Paquier <[email protected]>
Reviewed-by: Tom Lane <[email protected]>
Backpatch-through: 14
Security: CVE-2026-116332

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c65fee830f938e08a6f78034078e0253d65cd596
Author: Michael Paquier <[email protected]>

Modified Files
--------------
src/backend/utils/mmgr/portalmem.c             |  40 +++++++++-
src/test/regress/expected/portals_inflight.out | 103 +++++++++++++++++++++++++
src/test/regress/parallel_schedule             |   2 +-
src/test/regress/sql/portals_inflight.sql      |  94 ++++++++++++++++++++++
4 files changed, 234 insertions(+), 5 deletions(-)

Reply via email to