On 11/6/26 04:07, Tom Lane wrote:
> Tomas Vondra <[email protected]> writes:
>> Handle numeric overflow in numeric_minmax_multi_ops
> 
> Hi, this commit is making a few buildfarm members unhappy,
> eg at [1]:
> 
> In file included from brin_minmax_multi.c:72:0:
> brin_minmax_multi.c: In function 
> \342\200\230brin_minmax_multi_distance_numeric\342\200\231:
> ../../../../src/include/nodes/miscnodes.h:54:15: warning: the comparison will 
> always evaluate as \342\200\230true\342\200\231 for the address of 
> \342\200\230escontext\342\200\231 will never be NULL [-Waddress]
>   ((escontext) != NULL && IsA(escontext, ErrorSaveContext) && \\
>                ^
> brin_minmax_multi.c:2070:6: note: in expansion of macro 
> \342\200\230SOFT_ERROR_OCCURRED\342\200\231
>   if (SOFT_ERROR_OCCURRED(&escontext))
>       ^~~~~~~~~~~~~~~~~~~
> 
> We have seen this before, and the way to silence it is
> 
> -     if (SOFT_ERROR_OCCURRED(&escontext))
> +     if (escontext.error_occurred)
> 
>                       regards, tom lane
> 

Uh, I completely missed this report, and only noticed it now when I saw
the commit fixing it. Apologies and thanks for taking care of it!


Thanks

-- 
Tomas Vondra



Reply via email to