dblink: Refuse to use a connection that a dblink call is already using.

Previously, a dblink query that returned rows kept using its
connection after handing each row to the declared column type's input
function. That input function can run user-defined code (e.g., a
domain type with a CHECK constraint), so SQL can re-enter dblink while
an outer call is still reading results, and close the connection that
call is reading from. The close freed the connection object while the
outer call held a pointer to it, so the next libpq call read and wrote
freed memory.

dblink never had a rule about reentrancy. Calls that issued a new
query failed on their own, but by accident rather than by design:
libpq rejects a new query while one is in progress. It doesn't reject
reading a result, so a reentrant dblink_get_result() consumed a row
out of the outer query's single-row stream.

Fix this by marking a connection while a dblink call is materializing
a result from it, and refusing every other dblink call on that
connection until it's done.

Backpatch to all supported branches.

Reported-by: 안지용 <[email protected]>
Reviewed-by: Jacob Champion <[email protected]>
Reviewed-by: Greg Burd <[email protected]>
Backpatch-through: 14
Security: CVE-2026-120147

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/887f6fee58f46c93bec66d0f449a579e314552ae
Author: Masahiko Sawada <[email protected]>

Modified Files
--------------
contrib/dblink/dblink.c            | 140 ++++++++++++++++++++++++++++---
contrib/dblink/expected/dblink.out | 167 +++++++++++++++++++++++++++++++++++++
contrib/dblink/sql/dblink.sql      |  83 ++++++++++++++++++
3 files changed, 378 insertions(+), 12 deletions(-)

Reply via email to