On Thu, Jul 8, 2010 at 17:11, Magnus Hagander <mag...@hagander.net> wrote: > On Thu, Jul 8, 2010 at 17:04, Tom Lane <t...@sss.pgh.pa.us> wrote: >> m...@postgresql.org (Magnus Hagander) writes: >>> Log Message: >>> ----------- >>> Add support for TCP keepalives on Windows, both for backend and the new >>> libpq support. >> >> Buildfarm member narwhal doesn't like this patch. You have about six >> or eight hours to fix or revert it before beta3 wraps. > > Gah. Seems mingw is out of date with reality again. I'll go look for a > vm with it on and see if I can find how to do it there. > > (and yes, I even asked Dave to do a special run with that bf member > for me, and then forgot to check the result. sorry!)
Seems pretty simple - mingw doesn't have support for this. We have two ways to deal with that I think: 1) Disable it on mingw. 2) Include it in our custom headers. For #2, what we need to include is the define of SIO_KEEPALIVE_VALS as well as the definition of struct tcp_keepalive. We've done #2 before at least once, which worked well until mingw suddenly caught up and added it a while later. It's not like this is a new definition in windows, but we need to be ready for them to eventually do that. I guess there is: 3) write an autoconf test and provide them only when mingw doesn't have it. if we're going with #3, I'll respectfully have to ask somebod yelse to write the autoconf test, that's beyond me I think :-) Opinions on which way to go? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
