On Thu, Dec 30, 2010 at 9:55 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> I wrote:
>> Robert Haas <robertmh...@gmail.com> writes:
>>> This is cool, but on first blush your changes to
>>> add_paths_to_joinrel() appear to be total nonsense.  I think the
>>> problem is that have_nonmergeable_clause is really a misnomer - it's
>>> not clear until you read through the whole diff that this won't get
>>> set for inner/left joins.
>
>> Yeah, I wasn't totally satisfied with that variable name either.
>> Do you have a better idea?
>
> On reflection, how about inverting the flag's value and calling it
> mergejoin_allowed or some such?

Yeah, that's better.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Reply via email to