Work around gcc 4.6.0 bug that breaks WAL replay. ReadRecord's habit of using both direct references to tmpRecPtr and references to *RecPtr (which is pointing at tmpRecPtr) triggers an optimization bug in gcc 4.6.0, which apparently has forgotten about aliasing rules. Avoid the compiler bug, and make the code more readable to boot, by getting rid of the direct references. Improve the comments while at it.
Back-patch to all supported versions, in case they get built with 4.6.0. Tom Lane, with some cosmetic suggestions from Alex Hunsaker Branch ------ REL9_0_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/45d792f70272ed57b932816562f31c2f79426c2a Modified Files -------------- src/backend/access/transam/xlog.c | 37 +++++++++++++++++++++++------------ src/include/access/xlog_internal.h | 12 +++++----- 2 files changed, 30 insertions(+), 19 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers