On Wed, Aug 3, 2011 at 6:36 PM, Tom Lane <[email protected]> wrote: > I do however notice a vestigial reference to MAX_RANDOM_VALUE at line > 1063, which we probably should get rid of. What I think we probably > need instead, and don't have, is a check that "max - min + 1" doesn't > overflow.
Seems reasonable. Do you want to take care of that, or shall I do it? Off-hand, the easiest approach seems to be to define SAMESIGN in pgbench.c using the same definition we employ in various other places, and then copy the test we use in int4pl(). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
