Andrew Dunstan wrote: > > > On 11/26/2011 09:11 AM, Bruce Momjian wrote: > > \Andrew Dunstan wrote: > >> > >> On 11/26/2011 02:13 AM, Tom Lane wrote: > >>> Bruce Momjian<[email protected]> writes: > >>>> Modify pg_dump to use error-free memory allocation macros. This avoids > >>>> ignoring errors and call-site error checking. > >>> This appears to have broken the MSVC build. More generally, I'd like to > >>> object to arbitrarily moving a bunch of longstanding code from one file > >>> to another. What that is mainly going to accomplish is creating a big > >>> headache whenever we have to back-patch fixes that touch that code > >>> ... and what exactly did it buy in return? > >>> > >>> > >> > >> Was there any discussion of this change? It seems much too big for > >> something to be done without discussion, but I don't recall seeing > >> anything. (And it's probably seriously broken two patches I have in the > >> commitfest). > > The patch was posted Novembrer 14 and received no replies: > > > > http://archives.postgresql.org/pgsql-hackers/2011-11/msg00860.php > > > > Oh, I missed it. Sorry.
No problem. Tom is discussing if this is the best approach, and if it is the MSVC build needs to be fixed. I normally don't hold patches for two weeks but waited to be sure I was available to fix any breakage. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
