pg_upgrade: Fix exec_prog API to be less flaky The previous signature made it very easy to pass something other than the printf-format specifier in the corresponding position, without any warning from the compiler.
While at it, move some of the escaping, redirecting and quoting responsibilities from the callers into exec_prog() itself. This makes the callsites cleaner. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/088c065ce8e405fafbfa966937184ece9defcf20 Modified Files -------------- contrib/pg_upgrade/check.c | 9 +--- contrib/pg_upgrade/dump.c | 9 ++-- contrib/pg_upgrade/exec.c | 80 ++++++++++++++++++++------------------ contrib/pg_upgrade/pg_upgrade.c | 68 +++++++++++++-------------------- contrib/pg_upgrade/pg_upgrade.h | 9 ++-- contrib/pg_upgrade/server.c | 34 ++++++++--------- 6 files changed, 96 insertions(+), 113 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
