* Tom Lane (t...@sss.pgh.pa.us) wrote: > grep shows me a couple of other places where the result of ftello doesn't > seem to be getting checked for error. Odd that Coverity didn't notice > those.
At least two of those are in a #if 0 block... since 2001 (pg_backup_tar.c:_tarGetHeader). I'm thinking we may be better off removing that code rather than continuing to pull it along (and update it- there were at least three commits fixing things in that block after it had been #if 0'd out). Another technically had a check, but it was late, I've got a patch to improve that. The last is inside a snprintf() which is just building a string to call exit_horribly() with- seems like that's safe enough? Thanks, Stephen
signature.asc
Description: Digital signature