K, will check it out. Thanks! On Tuesday, March 4, 2014, Bruce Momjian <br...@momjian.us> wrote:
> On Sun, Mar 2, 2014 at 03:14:35AM +0000, Stephen Frost wrote: > > Various Coverity-spotted fixes > > > > A number of issues were identified by the Coverity scanner and are > > addressed in this patch. None of these appear to be security issues > > and many are mostly cosmetic changes. > > > > Short comments for each of the changes follows. > > > > Correct the semi-colon placement in be-secure.c regarding SSL retries. > > Remove a useless comparison-to-NULL in proc.c (value is dereferenced > > prior to this check and therefore can't be NULL). > > Add checking of chmod() return values to initdb. > > Fix a couple minor memory leaks in initdb. > > Fix memory leak in pg_ctl- involves free'ing the config file contents. > ---------------------------------------------------------------------- > > I am seeing a pg_ctl crash if you run 'pg_ctl status' when the server is > running: > > *** glibc detected *** pg_ctl: free(): invalid pointer: > 0x00000000011c42c8 *** > > The error is coming from the new free_readfile() function. I believe > the error was introduced in this commit. > > -- > Bruce Momjian <br...@momjian.us <javascript:;>> > http://momjian.us > EnterpriseDB http://enterprisedb.com > > + Everyone has their own god. + > >
