On 2014-05-05 13:24:15 -0400, Tom Lane wrote: > Andres Freund <[email protected]> writes: > > On 2013-10-10 02:43:20 +0000, Peter Eisentraut wrote: > >> Revive line type > > > That commit missed to update pg_type.h to the changed length of the line > > type. Patch attached. > > Ouch. Good thing we caught this now.
Yea. The only thing we could have done later is to allocate more memory and waste the space ondisk :(. I am really hoping to get pg into a state where it's sufficiently valgrind clean that we can run a buildfarm animal under valgrind. The newest release of valgrind helps there - e.g. some float bugs have been worked out. > In principle, fixing this breaks pg_upgrade'ability for anyone who was > using the line type before (presumably by compiling with > -DENABLE_LINE_TYPE). However, we're breaking things for them anyway by > changing the text representation, so that's probably not worth worrying > over. Agreed Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
