On Fri, Dec 19, 2014 at 02:09:10AM -0500, Noah Misch wrote:
> On Mon, Dec 15, 2014 at 09:27:38PM -0700, David G Johnston wrote:
> > Noah Misch-2 wrote
> > > Here are a couple of alternatives for the documentation text:
> > >
> > > The new default tablespace must not already contain any of the
> > > database's
> > > objects, and no one can be connected to the database.
> >
> > +1; though maybe...
> >
> > The newly assigned default tablespace must not contain any of the specified
> > database's objects but otherwise need not be empty. Additionally, there
> > must not be anyone connected to the database.
> >
> > This is a bit more verbose, and somewhat implied since newly created
> > databases have their default set, by definition, to one hat likely already
> > contains objects of other databases in the cluster, but does clarify the
> > specific confusion raised here. Re-reading I think the implicit version is
> > likely sufficiently clear though.
>
> That text, too, works for me.
I went with cleaner wording that just rearranges the text to avoid the
confusion. Attached patch applied.
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
diff --git a/doc/src/sgml/ref/alter_database.sgml b/doc/src/sgml/ref/alter_database.sgml
new file mode 100644
index 333db5b..95c7ac9
*** a/doc/src/sgml/ref/alter_database.sgml
--- b/doc/src/sgml/ref/alter_database.sgml
*************** ALTER DATABASE <replaceable class="PARAM
*** 78,84 ****
create privilege for the new tablespace.
This command physically moves any tables or indexes in the database's old
default tablespace to the new tablespace. The new default tablespace
! for this database must be empty, and no one can be connected to
the database. Tables and indexes in non-default tablespaces are
unaffected.
</para>
--- 78,84 ----
create privilege for the new tablespace.
This command physically moves any tables or indexes in the database's old
default tablespace to the new tablespace. The new default tablespace
! must be empty for this database, and no one can be connected to
the database. Tables and indexes in non-default tablespaces are
unaffected.
</para>
--
Sent via pgsql-committers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
