Improve configure test for the sse4.2 crc instruction. With optimizations enabled at least one compiler, clang 3.7, optimized away the crc intrinsics knowing that the result went on unused and has no side effects. That can trigger errors in code generation when the intrinsic is used, as we chose to use the intrinsics without any additional compiler flag. Return the computed value to prevent that.
With some more pedantic warning flags (-Wold-style-definition) the configure test failed to recognize the existence of _mm_crc32_u* intrinsics due to an independent warning in the test because the test turned on -Werror, but that's not actually needed here. Discussion: [email protected] Backpatch: 9.5, where the use of crc intrinsics was integrated. Branch ------ REL9_5_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/2c5c11ae9e0c5f4605fb9cdd2e8bd94fe0a06d95 Modified Files -------------- config/c-compiler.m4 | 7 +++---- configure | 10 ++++------ 2 files changed, 7 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
