On 22 March 2016 at 02:33, Andres Freund <[email protected]> wrote: > On 2016-03-21 09:25:18 -0400, Tom Lane wrote: >> Shouldn't we revert 6f1f34c92b11593e? AFAICS this patch isn't depending >> on that, but maybe I miss something. > > Hm. I'd guess that at least part of it is still required. AddSimpleFrontend() > afaics processes these variables, and I don't think the msvc stuff will > otherwise generate psqlscan.c in the first place. We probably could > move the knowledge to the explicit AddSimpleFrontend('pgbench') > site. But I'm not personally excited about tinkering with it...
Yeah, don't revert that. It half fixed things. As far as I can see both your changes were needed. On testing it seems the change to $frontend_extraincludes was required, but it all still works after removing src/bin/psql/psqlscan.l from $frontend_extrasource, although that's most likely only because psql compiled first, and created psqlscan.c. So I think both changes are required, we just end up running flex on psqlscan.l twice. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
