On 23/03/17 14:47, Petr Jelinek wrote: > I am looking into buildfarm failures. > > Looks like the clang issue (mylodon, longfin) is because we are missing > extern in include/replication/worker_internal.h for ApplyCacheContext. > > Still analyzing the rest. >
Ah missing fields in copy/equal function for AlterSubscriptionStmt. Attached patch adds the above mentioned extern and fixes the copy and equal functions. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c index 67c7de6..93d4eb2 100644 --- a/src/backend/nodes/copyfuncs.c +++ b/src/backend/nodes/copyfuncs.c @@ -4450,7 +4450,10 @@ _copyAlterSubscriptionStmt(const AlterSubscriptionStmt *from) { AlterSubscriptionStmt *newnode = makeNode(AlterSubscriptionStmt); + COPY_SCALAR_FIELD(kind); COPY_STRING_FIELD(subname); + COPY_STRING_FIELD(conninfo); + COPY_NODE_FIELD(publication); COPY_NODE_FIELD(options); return newnode; diff --git a/src/backend/nodes/equalfuncs.c b/src/backend/nodes/equalfuncs.c index 4d8e7fe..6b40b56 100644 --- a/src/backend/nodes/equalfuncs.c +++ b/src/backend/nodes/equalfuncs.c @@ -2199,7 +2199,10 @@ static bool _equalAlterSubscriptionStmt(const AlterSubscriptionStmt *a, const AlterSubscriptionStmt *b) { + COMPARE_SCALAR_FIELD(kind); COMPARE_STRING_FIELD(subname); + COMPARE_STRING_FIELD(conninfo); + COMPARE_NODE_FIELD(publication); COMPARE_NODE_FIELD(options); return true; diff --git a/src/include/replication/worker_internal.h b/src/include/replication/worker_internal.h index bf96d34..5bebca3 100644 --- a/src/include/replication/worker_internal.h +++ b/src/include/replication/worker_internal.h @@ -46,7 +46,7 @@ typedef struct LogicalRepWorker } LogicalRepWorker; /* Memory context for cached variables in apply worker. */ -MemoryContext ApplyCacheContext; +extern MemoryContext ApplyCacheContext; /* libpqreceiver connection */ extern struct WalReceiverConn *wrconn;
-- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers