On Thu, Apr 6, 2017 at 8:35 AM, Simon Riggs <si...@2ndquadrant.com> wrote: > Avoid SnapshotResetXmin() during AtEOXact_Snapshot() > > For normal commits and aborts we already reset PgXact->xmin, > so we can simply avoid running SnapshotResetXmin() twice. > > During performance tests by Alexander Korotkov, diagnosis > by Andres Freund showed PgXact array as a bottleneck. After > manual analysis by me of the code paths that touch those > memory locations, I was able to identify extraneous code > in the main transaction commit path. > > Avoiding touching highly contented shmem improves concurrent > performance slightly on all workloads, confirmed by tests > run by Ashutosh Sharma and Alexander Korotkov. > > Simon Riggs > > Discussion: canp8+jjdxe9b+b9f8cqt-luxxo0pbcb-szffmvadp+akqo4...@mail.gmail.com
Just like the last time you committed this, it seems to have broken the entire buildfarm. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
