On 2017-04-17 13:04:31 -0400, Tom Lane wrote: > Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > > On 4/5/17 23:51, Tom Lane wrote: > >> Fix integer-overflow problems in interval comparison. > > > This is failing cpluspluscheck now because C++ does not have > > _Static_assert, which is used in int128.h. > > Hmm. We could drop that assert, or move it to some .c file, or > wrap it in "#ifndef __cplusplus" ... but really it seems like a > more generic solution would be appropriate. This won't be the > last time somebody tries to do that, what with our increasing > use of inline functions. > > Maybe the definition of StaticAssertStmt should be tweaked based on > __cplusplus?
That seems reasonable, possibly with a cplusplus version check and then using static_assert()? Although I'd personally just mention that as a todo for later. > Or maybe the problem is cpluspluscheck's test methodology, > ie you ought to run configure with CC=c++ before trying to compile the > headers? That seems unlikely to work well for the moment... - Andres -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
