Change tupledesc->attrs[n] to TupleDescAttr(tupledesc, n). This is a mechanical change in preparation for a later commit that will change the layout of TupleDesc. Introducing a macro to abstract the details of where attributes are stored will allow us to change that in separate step and revise it in future.
Author: Thomas Munro, editorialized by Andres Freund Reviewed-By: Andres Freund Discussion: https://postgr.es/m/CAEepm=0ZtQ-SpsgCyzzYpsXS6e=kzwqk3g5ygn3mdv7a8da...@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2cd70845240087da205695baedab6412342d1dbe Modified Files -------------- contrib/dblink/dblink.c | 31 ++++-- contrib/file_fdw/file_fdw.c | 6 +- contrib/hstore/hstore_io.c | 22 ++-- contrib/pageinspect/heapfuncs.c | 8 +- contrib/pageinspect/rawpage.c | 2 +- contrib/postgres_fdw/deparse.c | 6 +- contrib/postgres_fdw/postgres_fdw.c | 10 +- contrib/spi/timetravel.c | 2 +- contrib/tablefunc/tablefunc.c | 42 ++++---- contrib/tcn/tcn.c | 3 +- contrib/test_decoding/test_decoding.c | 2 +- src/backend/access/brin/brin.c | 10 +- src/backend/access/brin/brin_inclusion.c | 6 +- src/backend/access/brin/brin_minmax.c | 6 +- src/backend/access/brin/brin_tuple.c | 2 +- src/backend/access/common/heaptuple.c | 95 ++++++++--------- src/backend/access/common/indextuple.c | 58 ++++++----- src/backend/access/common/printsimple.c | 4 +- src/backend/access/common/printtup.c | 22 ++-- src/backend/access/common/tupconvert.c | 47 +++++---- src/backend/access/common/tupdesc.c | 40 ++++---- src/backend/access/gin/ginbulk.c | 3 +- src/backend/access/gin/ginget.c | 2 +- src/backend/access/gin/ginutil.c | 14 +-- src/backend/access/gist/gistbuild.c | 4 +- src/backend/access/heap/heapam.c | 8 +- src/backend/access/heap/tuptoaster.c | 38 ++++--- src/backend/access/spgist/spgutils.c | 2 +- src/backend/bootstrap/bootstrap.c | 8 +- src/backend/catalog/heap.c | 24 +++-- src/backend/catalog/index.c | 15 +-- src/backend/catalog/toasting.c | 24 ++--- src/backend/commands/analyze.c | 2 +- src/backend/commands/cluster.c | 2 +- src/backend/commands/copy.c | 56 +++++----- src/backend/commands/createas.c | 2 +- src/backend/commands/indexcmds.c | 4 +- src/backend/commands/matview.c | 3 +- src/backend/commands/tablecmds.c | 57 +++++++---- src/backend/commands/typecmds.c | 8 +- src/backend/commands/view.c | 4 +- src/backend/executor/execExpr.c | 11 +- src/backend/executor/execExprInterp.c | 14 +-- src/backend/executor/execJunk.c | 2 +- src/backend/executor/execMain.c | 18 ++-- src/backend/executor/execReplication.c | 2 +- src/backend/executor/execSRF.c | 4 +- src/backend/executor/execScan.c | 2 +- src/backend/executor/execTuples.c | 13 ++- src/backend/executor/execUtils.c | 6 +- src/backend/executor/functions.c | 4 +- src/backend/executor/nodeAgg.c | 6 +- src/backend/executor/nodeModifyTable.c | 3 +- src/backend/executor/nodeSubplan.c | 4 +- src/backend/executor/nodeTableFuncscan.c | 15 +-- src/backend/executor/nodeValuesscan.c | 6 +- src/backend/executor/spi.c | 14 +-- src/backend/executor/tqueue.c | 4 +- src/backend/executor/tstoreReceiver.c | 13 ++- src/backend/optimizer/prep/preptlist.c | 2 +- src/backend/optimizer/prep/prepunion.c | 6 +- src/backend/optimizer/util/clauses.c | 2 +- src/backend/optimizer/util/plancat.c | 9 +- src/backend/parser/analyze.c | 2 +- src/backend/parser/parse_coerce.c | 9 +- src/backend/parser/parse_func.c | 2 +- src/backend/parser/parse_relation.c | 32 +++--- src/backend/parser/parse_target.c | 14 +-- src/backend/parser/parse_utilcmd.c | 15 +-- src/backend/replication/logical/proto.c | 8 +- src/backend/replication/logical/relation.c | 5 +- src/backend/replication/logical/reorderbuffer.c | 2 +- src/backend/replication/logical/worker.c | 6 +- src/backend/replication/pgoutput/pgoutput.c | 2 +- src/backend/rewrite/rewriteDefine.c | 2 +- src/backend/rewrite/rewriteHandler.c | 8 +- src/backend/utils/adt/json.c | 8 +- src/backend/utils/adt/jsonb.c | 8 +- src/backend/utils/adt/jsonfuncs.c | 2 +- src/backend/utils/adt/orderedsetaggs.c | 6 +- src/backend/utils/adt/rowtypes.c | 129 ++++++++++++++---------- src/backend/utils/adt/ruleutils.c | 16 +-- src/backend/utils/adt/tid.c | 6 +- src/backend/utils/adt/xml.c | 15 +-- src/backend/utils/cache/catcache.c | 5 +- src/backend/utils/cache/relcache.c | 55 +++++----- src/backend/utils/cache/typcache.c | 7 +- src/backend/utils/fmgr/funcapi.c | 15 +-- src/backend/utils/misc/pg_config.c | 4 +- src/include/access/htup_details.h | 6 +- src/include/access/itup.h | 6 +- src/include/access/tupdesc.h | 2 + src/pl/plperl/plperl.c | 26 ++--- src/pl/plpgsql/src/pl_comp.c | 2 +- src/pl/plpgsql/src/pl_exec.c | 50 ++++++--- src/pl/plpython/plpy_exec.c | 6 +- src/pl/plpython/plpy_resultobject.c | 18 +++- src/pl/plpython/plpy_typeio.c | 41 ++++---- src/pl/tcl/pltcl.c | 23 +++-- src/test/regress/regress.c | 4 +- 100 files changed, 805 insertions(+), 626 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers