On 2017-10-12 11:30:00 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > I've temporarily silenced that error by moving the stdlib.h include > > before the definition of restrict, but that seems fairly fragile. I > > primarily wanted to see whether there's other problems. At least thrips > > is is now happy. > > > I see a number of options to continue: > > - only define restrict on msvc 2013+ - for some reason woodlouse didn't > > complain about this problem, but I'm very doubtful that that's > > actually reliable. > > - rename restrict to pg_restrict. That's annoying because we'd have to > > copy the autoconf test. > > - live with the hack of including stdlib.h early, in pg_config.h.win32. > > - $better_idea > > I don't actually see why you need a #define at all --- "restrict" is the > standard spelling of the keyword no?
It is, but a lot of compilers name it differently, e.g. __restrict in the case of msvc. > I really do not like the stdlib.h hack: that amounts to assuming that > only stdlib.h does or ever will contain declspec(restrict). Maybe > you could get away with that if you were applying it only to long-dead > MSVC versions, but doing it "#if (_MSC_VER >= 1500)" is clearly going > to break someday. Yea, I dislike it quite a bit too. Unfortunately not even defining restrict to empty as if it were unsupported looks viable to me :( Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
