On 4/25/19 5:22 PM, Jonathan S. Katz wrote: > On 4/25/19 4:52 PM, Jonathan S. Katz wrote: >> On 4/25/19 3:20 PM, Joe Conway wrote: >>> On 4/25/19 3:06 PM, Stephen Frost wrote: >>>> Greetings, >>>> >>>> * Tom Lane (t...@sss.pgh.pa.us) wrote: >>>>> Joe Conway <m...@joeconway.com> writes: >>>>>> On 4/25/19 1:08 PM, Joe Conway wrote: >>>>>>> There is one image which can be used as an example though: >>>>>>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD >>>>> >>>>>> Here is a more precise URL: >>>>>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=doc/src/sgml/storage.sgml;hb=HEAD#l934 >>>>> >>>>> Comparing that to what I see at >>>>> >>>>> https://www.postgresql.org/docs/devel/storage-page-layout.html >>>>> >>>>> does not lead to a warm feeling about our images-in-docs stuff >>>>> really being ready for prime time. It works OK in some browsers >>>>> but others (at least Safari) cut off the image. >>>> >>>> Yeah, I'm seeing it cut off in Chrome too, initially, and then it seems >>>> to fix itself if I resize the window down from 4k (and stay fixed even >>>> if I then go back to the original, much larger, size). That seems like >>>> a CSS or layout issue though, not an issue with the image itself..? >>> >>> >>> Yeah, I see the same thing in Chrome -- maybe Jonathan has an idea what >>> is going on and how to best fix it? >> >> See[1] - I'm not sure if the final piece is committed -- if when it is I >> can finish fixing the pgweb part > OK, so I took a quick look at the existing SVGs with my patched version > of pgweb. > > The short answer is that it's better: the SVGs are not responsive, but > they are displaying. There still needs to be work on the SVGs as > indicated in that thread to make them responsive[1]. > > With that said, the pgweb patch does fix their current display at least > in full view, so I pushed the current patch to pgweb to do that. The fix > will take effect the next time the nightly docload runs, or if someone > on pginfra forces it to occur more quickly.
Good news - I did test against an older snapshot. With a newer snapshot, the SVG on the GIN implementation page[1] is responsive but not the one on the storage page layout[2], which is what the proposed fix in the other thread handles. Jonathan [1] https://www.postgresql.org/docs/devel/gin-implementation.html [2] https://www.postgresql.org/docs/devel/storage-page-layout.html
signature.asc
Description: OpenPGP digital signature
