On Fri, Nov 13, 2020 at 7:13 PM Tom Lane <t...@sss.pgh.pa.us> wrote:

> [ redirecting to pgsql-docs ]
>
> I wrote:
> > Edson Richter <edsonrich...@hotmail.com> writes:
> >> Further on the documentation: "When creating a range partition, the
> lower bound specified with FROM is an inclusive bound, whereas the upper
> bound specified with TO is an exclusive bound."
>
> >> I'm pretty sure I cannot find this statement in PostgreSQL 13
> documentation page about partitioning. May be this statement is in another
> page?
>
> > It's in the CREATE TABLE reference page.  Seems like it would be a good
> > idea to have it also in ddl.sgml's discussion of partitioning, though.
>
> I went to do that, and soon decided that section 5.11 (Table Partitioning)
> really could stand a fair amount of editorial attention.  There's a lot
> of less than pitch-perfect English, paragraphs that were evidently written
> with only minimal attention to nearby existing material, diving into the
> weedy details in even the earliest introductory paras, and so on.  I
> propose the attached.
>
>
Looks good to me (just read the patch), Thanks!  Just one suggestion toward
the top:

...allows you to (specify declaratively => declare) that a table is divided
into partitions. (specification becomes declaration further down)

I am curious as to your thoughts on unique indexes and whether/how to
better incorporate advice regarding the use of ON CONFLICT with
partitioning [1] vis-a-vis the overview's claim of:

"The partitioning substitutes for leading columns of indexes, reducing
index size and making it more likely that the heavily-used parts of the
indexes fit in memory" [2]

David J.

[1]
https://www.postgresql.org/message-id/CAKFQuwYLtjoPh6Crrr1b2e92NSWJDLPE1W08C63u3JU9RBjooA%40mail.gmail.com
[2]
https://www.postgresql.org/docs/current/ddl-partitioning.html#DDL-PARTITIONING-OVERVIEW

Reply via email to