> On 30 Nov 2021, at 20:59, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Vincas Dargis <vin...@gmail.com> writes: >> checking which random number source to use... /dev/urandom >> checking for /dev/urandom... >> configure: error: cannot check for file existence when cross compiling > > Hmm ... this evidently stems from 16f96c74d. > > AFAICS this is the only test in our configure script that is a hard > fail when cross-compiling, and I don't see a reason for it to be that. > We could just assume that /dev/urandom will be available --- that's no > worse than a lot of the other optimistic assumptions that configure > makes in that mode.
Agreed, I don't see a problem with that. I'm not terribly familiar with supporting cross compilation in autoconf, would a reasonable approach be to just remove the check altogether like the below sketch? diff --git a/configure.ac b/configure.ac index a5c10b8d56..80fe0de38d 100644 --- a/configure.ac +++ b/configure.ac @@ -2289,13 +2289,6 @@ elif test x"$PORTNAME" = x"win32" ; then AC_MSG_RESULT([Windows native]) else AC_MSG_RESULT([/dev/urandom]) - AC_CHECK_FILE([/dev/urandom], [], []) - - if test x"$ac_cv_file__dev_urandom" = x"no" ; then - AC_MSG_ERROR([ -no source of strong random numbers was found -PostgreSQL can use OpenSSL, native Windows API or /dev/urandom as a source of random numbers.]) - fi fi -- Daniel Gustafsson https://vmware.com/
