On Mon, Nov 20, 2017 at 04:45:48PM -0300, Martín Marqués wrote:
> New version of patch, without the --batch-mode option and using isatty()
> 

Great!

> +             fprintf(stderr, "waiting for checkpoint");
> +             if (isatty(fileno(stderr)))
> +                     fprintf(stderr, "\n");
> +             else
> +                     fprintf(stderr, "\r");

Here the condition should be inverted I think. The next condition should be 
used:

> if (!isatty(fileno(stderr)))
> ...

Otherwise pg_basebackup will insert '\n' in terminal instead '\r'.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Reply via email to