On Mon, Nov 20, 2017 at 7:46 AM, amul sul <sula...@gmail.com> wrote: > Thanks for fixing this function. Patch looks good to me, except column number > in the following errors message should to be 2. > > 354 +SELECT satisfies_hash_partition('mchash'::regclass, 2, 1, > NULL::int, NULL::int); > 355 +ERROR: column 1 of the partition key has type "text", but > supplied value is of type "integer" > > Same at the line # 374 & 401 in the patch.
Oops. Looks like the indexing should be 1-based rather than 0-based. Committed with that change. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company