On Wed, Nov 29, 2017 at 9:26 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > I'd still like a review of this patch.
I don't think there's much to review apart from this one issue. Neither Tom nor I seem to be convinced about: +/* not worth providing a workaround */ I suggested that it was worth providing a workaround, and Tom suggested that the case might be so rare that we could just #error if happens. If you agree that it's never likely to come up, I suggest going with Tom's #error proposal; otherwise, I suggest trying to find a workable workaround. Apart from that, the only thing I see is that it seems like the comment block just before your code changes might need some updating. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
