On 2017-11-30 00:45:44 +0100, Petr Jelinek wrote: > I don't understand. I mean sure the SnapBuildWaitSnapshot() can live > with it, but the problematic logic happens inside the > XactLockTableInsert() and SnapBuildWaitSnapshot() has no way of > detecting the situation short of reimplementing the > XactLockTableInsert() instead of calling it.
Right. But we fairly trivially can change that. I'm remarking on it because other people's, not yours, suggestions aimed at making this bulletproof. I just wanted to make clear that I don't think that's necessary at all. Greetings, Andres Freund