On Thu, Nov 30, 2017 at 1:48 PM, Robert Haas <robertmh...@gmail.com> wrote: > One difference between those two macros is that IndexTupleSize > forcibly casts the argument to IndexTuple, which means that you don't > get any type-checking when you use that one. I suggest that in > addition to removing IndexTupleDSize as proposed, we also remove that > cast. It seems that the only place which relies on that cast > currently is btree_xlog_split. > > Therefore I propose the attached patch instead.
+1 to both points. I specifically recall being annoyed by both issues, more than once. -- Peter Geoghegan
