Robert Haas wrote: > On Fri, Dec 15, 2017 at 5:18 PM, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > We have two options for marking valid: > > > > 1. after each ALTER INDEX ATTACH, verify whether the set of partitions > > that contain the index is complete; if so, mark it valid, otherwise do > > nothing. This sucks because we have to check that over and over for > > every index that we attach > > > > 2. We invent yet another command, say > > ALTER INDEX <idx-on-parent> VALIDATE > > If ALTER INDEX .. ATTACH is already taking AEL on the parent, then I > think it might as well try to validate while it's at it. But if not > then we might want to go with #2.
The problem I have with it is that restoring a dump containing indexes on partitions becomes a O(N^2) deal as it has to do the full check once for every index we attach. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
