On 11/29/2017 08:58 AM, Thomas Munro wrote: > Hi hackers, > > Andrew Gierth complained off-list that TupleDescCopy() doesn't clear > atthasdef. Yeah, that's an oversight. The function is new in commit > cc5f81366c36 and was written by me to support "flat" (pointer-free) > tuple descriptors for use in DSM. Following the example of > CreateTupleDescCopy() I think it should also clear attnotnull and > attidentity. Please see attached.
This trivial patch is a clear oversight in the original patch. Thank you to Andrew for some explanation off-list to help me understand tuple descriptors better. Ready for committer. -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
