On 1/8/18 08:14, Michael Paquier wrote: > On Sat, Jan 06, 2018 at 09:10:51AM +0900, Michael Paquier wrote: >> On Sat, Jan 6, 2018 at 2:56 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> >> wrote: >> Good idea as a whole, but I don't think this is the right approach. As >> we include $(bindir) in PATH when running the prove command, why not >> getting the include path from "pg_config --includedir"? > > So, I have been looking at that, and I propose the following > counter-patch which implements this idea by adding a new routine as > TestLib::config_check which is able to check within pg_config.h if a > given regexp matches or not for the installation on which TAP tests are > being run. I have tested with Postgres compiled with both OpenSSL 1.0.1 > and 1.0.2, in which case the connection test respectively fails and > passes, causing the test to be correctly handled. This is based on > Peter's patch upthread.
Committed. I like counter-patches. (I renamed the function a bit to check_pg_config, to make the naming similar to other functions in TestLib.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services