Thanks for making those changes. On 11 January 2018 at 04:00, Amit Khandekar <amitdkhan...@gmail.com> wrote: > Yes, I understand that there won't be any update scan plans. But, with > the modifications done in ExecInitModifyTable(), I wanted to run that > code with this scenario where there are no partitions, to make sure it > does not behave weirdly or crash. Any suggestions for comments, given > this perspective ? For now, I have made the comment this way: > > -- Check that partition-key UPDATE works sanely on a partitioned table > that does not have any child partitions.
Sounds good. >> 18. Why two RESET SESSION AUTHORIZATIONs? >> >> reset session authorization; >> drop trigger trig_d_1_15 ON part_d_1_15; >> drop function func_d_1_15(); >> -- Policy expression contains SubPlan >> reset session authorization; > > The second reset is actually in a different paragraph. The reason it's > there is to ensure we have reset it regardless of the earlier cleanup. hmm, I was reviewing the .out file, which does not have the empty lines. Still seems a bit surplus. > Attached v35 patch. Thanks. Thanks. I'll try to look at it soon. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
