On 17 January 2018 at 03:58, Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: >> 9. Error details claim that p2_a_idx is not a partition of p. >> Shouldn't it say table "p2" is not a partition of "p"? > > You missed the "on" in the DETAIL: > DETAIL: Index "p2_a_idx" is not on a partition of table "p". > You could argue that this is obscurely worded, but if you look at the > command: > ALTER INDEX p_a_idx ATTACH PARTITION p2_a_idx; > nowhere is table p2 mentioned, so I'm not sure it's a great idea to > mention the table in the error message.
I think I did miss the "on". >> 10. You've added code to get_relation_info() to handle partitioned >> indexes, but that code is skipped [...] >> The new code should either be removed, or you should load the index >> list for a partitioned table. > > That's a leftover from previous versions too. YAGNI principle says I > should remove it rather than activate it, I think, since the optimizer > is not going to use the data for anything. Agreed. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
