On Wed, 24 Jan 2018 20:20:41 +0300 Arthur Zakirov <a.zaki...@postgrespro.ru> wrote:
Hi, I did some review of the patch. In 0001 there are few lines where is only indentation has changed. 0002: - TsearchShmemSize - calculating size using hash_estimate_size seems redundant since you use DSA hash now. - ts_dict_shmem_release - LWLockAcquire in the beginning makes no sense, since dict_table couldn't change anyway. 0003: - ts_dict_shmem_location could return IspellDictData, it makes more sense. 0006: It's very subjective, but I think it would nicer to call option as Shared (as property of dictionary) or UseSharedMemory, the boolean option called SharedMemory sounds weird. Overall the patches look good, all tests passed. I tried to broke it in few places where I thought it could be unsafe but not succeeded. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company
