On Sat, Feb 10, 2018 at 7:19 AM, Tomas Vondra <[email protected]>
wrote:
> Hi,
>
> On 02/07/2018 10:24 AM, Pavan Deolasee wrote:
> >
>
> if (startWAL < GetXactWALBytes())
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> errmsg("cannot write to database ...")));
>
> I think this actually fails to enforce the rule, because some writes may
> not produce WAL (think of unlogged tables). I also suspect it may be
> incorrect "in the opposite direction" because a query may not do any
> changes and yet it may produce WAL (e.g. due to wal_hint_bits=true).
>
> So we may need to think of a different way to enforce this ...
Yes, this does look problematic.
Thanks,
Pavan
--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
