On Fri, Mar 2, 2018 at 6:23 AM, Magnus Hagander <mag...@hagander.net> wrote: > Another quick note -- we need to assert that the size of the buffer is > actually divisible by BLCKSZ. I don't think it's a common scenario, but it > could break badly if somebody changes BLCKSZ. Either that or perhaps just > change the TARSENDSIZE to be a multiple of BLCKSZ.
I think that this patch needs to support all block sizes that are otherwise supported -- failing an assertion doesn't seem like a reasonable option, unless it only happens for block sizes we don't support anyway. +1 for the feature in general. I think this would help a lot of peple. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
