Masahiko Sawada wrote: > On Tue, Mar 6, 2018 at 8:35 AM, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote:
> > Therefore, I'm inclined to make this function raise a warning, then > > return a substitute value (something like "unrecognized type XYZ"). > > [...] > > I agree with you about not hiding the actual reason for the error but > if we raise a warning at logicalrep_typmap_gettypname don't we call > slot_store_error_callback recursively? Hmm, now that you mention it, I don't really know. I think it's supposed not to happen, since calling ereport() again opens a new recursion level, but then maybe errcontext doesn't depend on the recursion level ... I haven't checked. This is why the TAP test would be handy :-) > Agreed. Will add a TAP test. Great. This patch waits on that, then. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
