Hi Here are two patches fixing comments. 0001 A comment in add_paths_to_append_rel() mentions the number of paths instead of number of workers by mistake. Fixed it.
0002 Commit b5635948ab165b6070e7d05d111f966e07570d81 added a single grouping_sets_data argument instead of two lists related to grouping sets to create_grouping_paths(), but forgot to update the prologue of the function. Fixed it. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company
From 053a0f4e77ad14a08f7fb8fb96152fae4406bd9a Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> Date: Wed, 14 Mar 2018 16:24:03 +0530 Subject: [PATCH 1/2] Fix typo in one of comments in add_paths_to_append_rel() The comment mentions the number of paths instead of number of workers by mistake. Ashutosh Bapat --- src/backend/optimizer/path/allpaths.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c index 1c792a0..c58d7b8 100644 --- a/src/backend/optimizer/path/allpaths.c +++ b/src/backend/optimizer/path/allpaths.c @@ -1574,7 +1574,7 @@ add_paths_to_append_rel(PlannerInfo *root, RelOptInfo *rel, /* * If the use of parallel append is permitted, always request at least - * log2(# of children) paths. We assume it can be useful to have + * log2(# of children) workers. We assume it can be useful to have * extra workers in this case because they will be spread out across * the children. The precise formula is just a guess, but we don't * want to end up with a radically different answer for a table with N -- 1.7.9.5
From b43a2e5ee83cda8d41b946eaa7387adc54256893 Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> Date: Wed, 14 Mar 2018 16:29:14 +0530 Subject: [PATCH 2/2] Fix input argument description of create_grouping_paths() Commit b5635948ab165b6070e7d05d111f966e07570d81 added a single grouping_sets_data argument instead of two lists related to grouping sets to create_grouping_paths(), but forgot to update the prologue of the function. Ashutosh Bapat. --- src/backend/optimizer/plan/planner.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c index 24e6c46..9c2b115 100644 --- a/src/backend/optimizer/plan/planner.c +++ b/src/backend/optimizer/plan/planner.c @@ -3643,9 +3643,7 @@ estimate_hashagg_tablesize(Path *path, const AggClauseCosts *agg_costs, * input_rel: contains the source-data Paths * target: the pathtarget for the result Paths to compute * agg_costs: cost info about all aggregates in query (in AGGSPLIT_SIMPLE mode) - * rollup_lists: list of grouping sets, or NIL if not doing grouping sets - * rollup_groupclauses: list of grouping clauses for grouping sets, - * or NIL if not doing grouping sets + * gd: grouping sets data like list of grouping sets and their grouping clauses * * Note: all Paths in input_rel are expected to return the target computed * by make_group_input_target. -- 1.7.9.5
