Peter Geoghegan wrote: > On Fri, Mar 16, 2018 at 11:21 AM, Alvaro Herrera > <alvhe...@alvh.no-ip.org> wrote: > > So ExecInsert receives the ModifyTableState, and separately it receives > > arbiterIndexes and the OnConflictAction, both of which are members of > > the passed ModifyTableState. I wonder why does it do that; wouldn't it > > be simpler to extract those members from the node? > > > Or is there another reason to pass the index list? > > It works that way pretty much by accident, as far as I can tell. > Removing the two extra arguments sounds like a good idea.
Great, thanks. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
