Peter Eisentraut wrote: > On 3/21/18 19:18, Alvaro Herrera wrote: > > Here's v8, which addresses all your comments except the doc updates. I > > added a few more tests, too. Thanks for the review! I intend to commit > > this shortly, probably not before Friday to give some more time for > > others to review/comment. > > Looks good, does what it needs to do. > > A small fixup attached. In particular, I renamed one trigger from "f", > which created confusing output, looking like a boolean column.
Thanks! > This comment in the tests I don't understand: > > -- verify that the FOR UPDATE OF (columns) is propagated correctly > > I don't see how this applies to the tests that follow. Does this have > something to do with the subsequent foreign keys patch perhaps? Not at all ... I meant "AFTER UPDATE OF columns" (used as a firing event). Not sure how I typo'ed it that badly. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
