On Sun, Mar 25, 2018 at 9:13 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 25 March 2018 at 20:09, David Rowley <david.row...@2ndquadrant.com> wrote: >> On 15 March 2018 at 21:33, Andrew Dunstan >> <andrew.duns...@2ndquadrant.com> wrote: >>> rebased and mostly indented patch version attached. >> >> Thanks. I've attached a version of this which applies, builds and >> passes the regression tests on current master. >> >> Some conflicts were caused by 325f2ec555 and there was a new call to >> heap_attisnull which needed to be updated. >> >> I'll look over this now. > > I've attached a delta patch against the v17 patch that I attached > earlier. I didn't change much, but there did seem to be a few places > where the patch was not properly setting atthasmissing to false. Most > of the rest is just cosmetic stuff > > With the attached applied, I'm happy to mark the patch as ready for > committer, however, Petr is also signed up to review, so will defer to > him to see if he has any comments before altering the commitfest app's > state.
Thanks for this, all looks good. Here is the consolidate patch rebased. If there are no further comments I propose to commit this in a few days time. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
