Thanks Nikita! On Tue, Mar 27, 2018 at 12:07 AM, Nikita Glukhov <n.glu...@postgrespro.ru> wrote:
> On 26.03.2018 17:19, David Steele wrote: > > On 2/20/18 10:14 AM, Haozhou Wang wrote: >> >>> Thank you very much for your review! >>> >>> I attached a new patch with typo fixed. >>> >> I think it's a bit premature to mark this Ready for Committer after a >> review consisting of a few typos. Anthony only said that he started >> looking at it so I've marked it Needs Review. >> > > Hi. > > I also have looked at this patch and found some problems. > Attached fixed 3th version of the patch: > * initialization of arg->u.scalar was moved into PLy_output_setup_func() > * added range checks for int16 and int32 types > * added subroutine PLyInt_AsLong() for correct handling OverflowError > that can > be thrown from PyInt_AsLong() > * casting from Python float to PostgreSQL numeric using > PyFloat_AsDouble() was > removed because it can return incorrect result for Python long and > float8_numeric() uses float8 and numeric I/O functions > * fixed whitespace > > > -- > Nikita Glukhov > > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company > > -- Regards, Haozhou
