On Monday, October 11, 2021 11:02 PM vignesh C <vignes...@gmail.com> wrote: > The attached v39 patch has the fixes for the above issues.
Thanks for the updates. I have a few minor suggestions about the testcases in the v39-0003-Test patch. 1) +-- alter publication drop CURRENT_SCHEMA +ALTER PUBLICATION testpub1_forschema DROP ALL TABLES IN SCHEMA CURRENT_SCHEMA; +\dRp+ testpub1_forschema Since we already tested CURRENT_SCHEMA in various CREATE PUBLICATION cases, maybe we don't need to test it again in SET/DROP/ADD cases. 2) +-- alter publication set schema +ALTER PUBLICATION testpub1_forschema SET ALL TABLES IN SCHEMA pub_test1; +\dRp+ testpub1_forschema + +-- alter publication set multiple schema +ALTER PUBLICATION testpub1_forschema SET ALL TABLES IN SCHEMA pub_test1, pub_test2; +\dRp+ testpub1_forschema + I think the multiple schemas testcase is sufficient, maybe we can remove the single schema case. 3) + +-- alter publication set it with the same schema +ALTER PUBLICATION testpub1_forschema SET ALL TABLES IN SCHEMA pub_test1, pub_test2; +\dRp+ testpub1_forschema ISTM, we didn't have some special code path for this case, maybe we can remove this testcase. Best regards, Hou zj
