Hi hackers, I noticed that `make install` updates modification time for all installed headers. This leads to recompilation of all dependent objects, which is inconvenient for example when working on a third-party extension. A way to solve this would be to pass `INSTALL="install -p"` to `configure`, to make `install` preserve the timestamp. After this, a new problem arises -- the `src/include/Makefile` doesn't use `install` for all headers, but instead uses `cp`. This patch adds `-p` switch to `cp` invocation in these files, to make it preserve timestamps. Combined with the aforementioned install flag, it allows a developer to hack on both postgres and a third-party extension at the same time, without the unneeded recompilation.
-- Alexander Kuzmenkov Timescale
diff --git a/src/include/Makefile b/src/include/Makefile index 5f257a958c..27242ff910 100644 --- a/src/include/Makefile +++ b/src/include/Makefile @@ -48,14 +48,16 @@ install: all installdirs $(INSTALL_DATA) utils/fmgroids.h '$(DESTDIR)$(includedir_server)/utils' $(INSTALL_DATA) utils/fmgrprotos.h '$(DESTDIR)$(includedir_server)/utils' # We don't use INSTALL_DATA for performance reasons --- there are a lot of files -# (in fact, we have to take some pains to avoid overlength shell commands here) - cp $(srcdir)/*.h '$(DESTDIR)$(includedir_server)'/ +# (in fact, we have to take some pains to avoid overlength shell commands here). +# We preserve timestamps while copying to avoid recompiling dependent objects +# such as third-party extensions. + cp -p $(srcdir)/*.h '$(DESTDIR)$(includedir_server)'/ for dir in $(SUBDIRS); do \ - cp $(srcdir)/$$dir/*.h '$(DESTDIR)$(includedir_server)'/$$dir/ || exit; \ + cp -p $(srcdir)/$$dir/*.h '$(DESTDIR)$(includedir_server)'/$$dir/ || exit; \ done ifeq ($(vpath_build),yes) for file in catalog/schemapg.h catalog/system_fk_info.h catalog/pg_*_d.h parser/gram.h storage/lwlocknames.h utils/probes.h; do \ - cp $$file '$(DESTDIR)$(includedir_server)'/$$file || exit; \ + cp -p $$file '$(DESTDIR)$(includedir_server)'/$$file || exit; \ done endif cd '$(DESTDIR)$(includedir_server)' && chmod $(INSTALL_DATA_MODE) *.h
